<html>
<head><meta charset="utf-8"><title>Label for perf regressions · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html">Label for perf regressions</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="243515794"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243515794" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243515794">(Jun 22 2021 at 13:29)</a>:</h4>
<p>With <a href="https://github.com/rust-lang/rustc-perf/pull/881">rustc-perf#881</a> we are now categorizing performance runs when they happen. Should we label performance regressions so that they can be tracked and triaged in the issue system? Something like <code>c-perf-regressions</code>?</p>



<a name="243516460"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243516460" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243516460">(Jun 22 2021 at 13:34)</a>:</h4>
<p>Seems like a good idea, I don't know about "c" -- maybe just perf-regressed/perf-improved/perf-neutral?</p>



<a name="243519972"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243519972" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243519972">(Jun 22 2021 at 13:57)</a>:</h4>
<p>I'm not sure what the logic behind the labeling system in rust-lang/rust is so I'll differ to you on that. I do wonder if the perf-improved and perf-neutral are useful or not.</p>



<a name="243520832"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243520832" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243520832">(Jun 22 2021 at 14:02)</a>:</h4>
<p>yeah, I don't know</p>



<a name="243520843"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243520843" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243520843">(Jun 22 2021 at 14:02)</a>:</h4>
<p>I'm not sure how much we'd get out of the labels</p>



<a name="243520865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243520865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243520865">(Jun 22 2021 at 14:02)</a>:</h4>
<p>do we have some goal with looking back using those labels?</p>



<a name="243522817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243522817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243522817">(Jun 22 2021 at 14:15)</a>:</h4>
<p>I'd like to use this as a way to triage performance regressions. Currently we rely on the triage report to remember which previous PRs caused regressions. This is a manual process that requires triage generators to check previous triage reports and follow up. It's _very_ easy for performance regressions to just be forgotten. With the labeling system we could easily do automated triaging sweeps where we check on unresolved performance regressions that have not been solved (or at the very least explicitly labeled as "won't fix").</p>



<a name="243522965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243522965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243522965">(Jun 22 2021 at 14:16)</a>:</h4>
<p>I imagine eventually we could have a process similar to <a class="stream" data-stream-id="242269" href="/#narrow/stream/242269-t-release.2Ftriage">#t-release/triage</a> for ensuring that performance issues are always addressed in some way (either by fixing the issue or by deciding the regression is acceptable).</p>



<a name="243523319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243523319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243523319">(Jun 22 2021 at 14:19)</a>:</h4>
<p>By the way, this was explicitly discussed in the "short-term performance process review" we had. The proposal explicitly laid out this vision above ^^ - so this isn't something we haven't discussed before . Of course, it's fine if we decide that it's not useful after all <span aria-label="blush" class="emoji emoji-1f60a" role="img" title="blush">:blush:</span></p>



<a name="243524026"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243524026" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243524026">(Jun 22 2021 at 14:23)</a>:</h4>
<p>Yeah, I recall something to this effect -- I didn't quite recall whether that was labels or some other method</p>



<a name="243524062"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243524062" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243524062">(Jun 22 2021 at 14:23)</a>:</h4>
<p>but labels seem to make sense</p>



<a name="243524322"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243524322" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243524322">(Jun 22 2021 at 14:25)</a>:</h4>
<p>I think not looking at neutral or improvements is necessary, then</p>



<a name="243527735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243527735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243527735">(Jun 22 2021 at 14:48)</a>:</h4>
<p>Do we think this needs an FCP? Or how should we go about doing this?</p>



<a name="243528063"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243528063" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243528063">(Jun 22 2021 at 14:50)</a>:</h4>
<p>I think just making it happen in the rustc-perf repo makes sense</p>



<a name="243528437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243528437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243528437">(Jun 22 2021 at 14:53)</a>:</h4>
<p>I assume the label needs to be added first to the repo right? (or does the bot create the label if it doesn't exist?)</p>



<a name="243529492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/243529492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#243529492">(Jun 22 2021 at 14:59)</a>:</h4>
<p>I think github's api just implicitly creates it</p>



<a name="244021341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244021341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244021341">(Jun 26 2021 at 15:51)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> it turns out the that the bot doesn't have permission to make the labels: <a href="https://github.com/rust-lang/rust/pull/86525#issuecomment-868593482">https://github.com/rust-lang/rust/pull/86525#issuecomment-868593482</a>. Would you be able to fix that?</p>



<a name="244021438"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244021438" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244021438">(Jun 26 2021 at 15:53)</a>:</h4>
<p>The label should get added to triagebot.toml I suspect in the root - anyone should be able to set it</p>



<a name="244118274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244118274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244118274">(Jun 28 2021 at 09:04)</a>:</h4>
<p>Do we want anyone to be able to set it? I'm unsure if we've had issues with abuse before.</p>



<a name="244118511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244118511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244118511">(Jun 28 2021 at 09:07)</a>:</h4>
<p>Here's a pr for that: <a href="https://github.com/rust-lang/triagebot/pull/1409">https://github.com/rust-lang/triagebot/pull/1409</a></p>



<a name="244131794"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244131794" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244131794">(Jun 28 2021 at 11:39)</a>:</h4>
<p>It needs to go on rust-lang/rust, each repository has it's own config</p>



<a name="244131824"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244131824" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244131824">(Jun 28 2021 at 11:39)</a>:</h4>
<p>I don't think we've seen abuse really of labels quite yet</p>



<a name="244131987"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244131987" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244131987">(Jun 28 2021 at 11:41)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/86687">https://github.com/rust-lang/rust/pull/86687</a> should do it</p>



<a name="244132430"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244132430" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244132430">(Jun 28 2021 at 11:46)</a>:</h4>
<p>Ah ok thanks! Should the pr on triagebot itself be closed?</p>



<a name="244138241"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244138241" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244138241">(Jun 28 2021 at 12:42)</a>:</h4>
<p>Yeah</p>



<a name="244255536"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244255536" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244255536">(Jun 29 2021 at 09:41)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I think we should make an announcement during the compiler meeting about the new performance categorization and labeling so make sure everyone is on the same page. I'll work on that.</p>



<a name="244265300"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244265300" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244265300">(Jun 29 2021 at 11:23)</a>:</h4>
<p>Great idea!</p>



<a name="244539126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244539126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244539126">(Jul 01 2021 at 09:21)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> thoughts on this as the announcement?<br>
The perf team is changing the compiler perf process to help make tracking compiler performance regressions easier. These are the changes made so far, and how they might impact you:</p>
<ul>
<li>The perf bot now attempts to categorize perf runs as "improvement", "regression", "mixed", or no category at all (i.e., perf did not significantly change), and it includes this in the summary section of the comment posted to the PR. <ul>
<li><strong>What you should do</strong>: This is meant as an _aid_ when analyzing perf runs. Please continue to check the perf output and see if your interpretation matches the categorization. If it does not, file an issue in rust-lang/rustc-perf.</li>
</ul>
</li>
<li>The perf bot also adds the GitHub label <code>perf-regression</code> if the run is categorized as a regression or mixed. It removes this label if the performance run yields no changes or perf improvements. This means if you make changes that improve the perf of your PR, it will automatically remove the regression label.<ul>
<li><strong>What you should do</strong>: Not all PRs labeled as <code>perf-regressions</code> need to have their performance regressions fixed. Regressions can be acceptable (e.g., for bug fixes). However, if you believe the regression is justified, please leave a short comment as to why and add the label <code>perf-regression-justified</code>. (note: <a href="https://github.com/rust-lang/rust/pull/86779">https://github.com/rust-lang/rust/pull/86779</a> must land first before this is possible for everyone)</li>
</ul>
</li>
<li>Soon the perf team will change the perf triage process to include tracking of these labels to ensure that every performance regression is either fixed or has a written justification. </li>
</ul>
<p>This is just the beginning of perf process improvements. If you'd like to discuss the future of the compiler performance process, drop by <a class="stream" data-stream-id="247081" href="/#narrow/stream/247081-t-compiler.2Fperformance">#t-compiler/performance</a> .</p>



<a name="244539409"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244539409" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244539409">(Jul 01 2021 at 09:23)</a>:</h4>
<p>I'm starting to think that labeling perf improvements could also be helpful for tracking purposes but only somewhat. Is adding a new label associated with any cost (maintenance or cognitive overhead wise)?</p>



<a name="244551313"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244551313" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244551313">(Jul 01 2021 at 11:26)</a>:</h4>
<p>No, labels are essentially free</p>



<a name="244551375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244551375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244551375">(Jul 01 2021 at 11:27)</a>:</h4>
<p>We should make sure that the justified label exists and can be set by anyone, updating triagebot.toml to blanket allow perf-* is probably a good idea</p>



<a name="244559457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244559457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244559457">(Jul 01 2021 at 12:47)</a>:</h4>
<p>I'll do that</p>



<a name="244560087"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244560087" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244560087">(Jul 01 2021 at 12:51)</a>:</h4>
<p>Random question: do we have any oversight on changed labels? Making it open to anyone is the right move, but it might be nice to have a bot that watches certain labels and simply tracks if a label is changed by someone unexpected. We could define an "unexpected person" as anyone not in a rust team or the author of the PR/issue. This could allow for casual, low-cost oversight.</p>



<a name="244561101"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244561101" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244561101">(Jul 01 2021 at 12:59)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/86779">https://github.com/rust-lang/rust/pull/86779</a></p>



<a name="244569137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244569137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244569137">(Jul 01 2021 at 13:52)</a>:</h4>
<p>Hm, I don't think we track that at all today -- not really clear where we'd put that information if we did</p>



<a name="244569174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244569174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244569174">(Jul 01 2021 at 13:52)</a>:</h4>
<p>I've not really seen any issues for the most part.</p>



<a name="244569780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244569780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244569780">(Jul 01 2021 at 13:56)</a>:</h4>
<p>Yea, just more of a curiosity at this point. Should be easy to set up if ever became an issue.</p>



<a name="244617560"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244617560" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244617560">(Jul 01 2021 at 19:49)</a>:</h4>
<p>Does it only categorize instruction counts or does it look at the other statistics too? E.g. compiler build time?</p>



<a name="244617976"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Label%20for%20perf%20regressions/near/244617976" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Label.20for.20perf.20regressions.html#244617976">(Jul 01 2021 at 19:53)</a>:</h4>
<p>just instruction counts today</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>